Page MenuHomeFreeBSD

Fix test timeout: common.dtraceUtil.t_dtrace_contrib.tst_DestructWithFunction_d_ksh
ClosedPublic

Authored by lwhsu on Jul 20 2017, 6:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 12 2024, 2:59 AM
Unknown Object (File)
Feb 11 2024, 6:10 PM
Unknown Object (File)
Jan 18 2024, 2:54 AM
Unknown Object (File)
Dec 20 2023, 2:13 AM
Unknown Object (File)
Dec 9 2023, 11:45 PM
Unknown Object (File)
Nov 25 2023, 6:35 PM
Unknown Object (File)
Nov 25 2023, 12:37 PM
Unknown Object (File)
Oct 4 2023, 2:47 AM
Subscribers

Details

Summary

This test timeout on a quiet system because there is nobody triggers read probefunc while test execution.

Add a delay-executed cat command to generate some noise

Test Plan

cd /usr/tests/cddl/usr.sbin/dtrace/common/dtraceUtil && kyua debug t_dtrace_contrib:tst.DestructWithFunction.d.ksh

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10648
Build 11052: arc lint + arc unit

Event Timeline

It might be a good idea to increase the sleep time in the backgrounded process to avoid clock skew, but this should work. Thanks!!

In D11673#241834, @ngie wrote:

It might be a good idea to increase the sleep time in the backgrounded process to avoid clock skew, but this should work. Thanks!!

In the long run I would modify dtest (test suite driver) to enable execute some post-actions.

Another thought is converting this test case to tst.DestructWithFunction.d and tst.DestructWithFunction.d.exe, to prevent race condition.

Another thought is converting this test case to tst.DestructWithFunction.d and tst.DestructWithFunction.d.exe, to prevent race condition.

Or just kill the shell process from within the script. There are many dtrace tests that do this.

lwhsu edited edge metadata.

Use a subprocess to execute auxiliary program and recycle it after test

ngie requested changes to this revision.Jul 24 2017, 5:21 PM
ngie added inline comments.
cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/dtraceUtil/tst.DestructWithFunction.d.ksh
45

Could you please add a sleep 0.1 here to avoid burning CPU too badly? Both FreeBSD and Solaris's version of sleep(1) support floating point precision.

This revision now requires changes to proceed.Jul 24 2017, 5:21 PM
lwhsu edited edge metadata.

Add a sleep(1) to avoid CPU busy loop.

This revision is now accepted and ready to land.Jul 25 2017, 10:25 AM
This revision was automatically updated to reflect the committed changes.