iflib - use proper max segment size for DMA
ClosedPublic
Actions

Authored by krzysztof.galazka_intel.com on Jun 29 2017, 9:59 AM.

Details

Reviewers

kmacy
sbruno

Group Reviewers

Intel Networking

Commits

rS320611: iflib - flib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size.

Summary

iflib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size.

Test Plan

Compile-tested with minimal performance testing.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

krzysztof.galazka_intel.com created this revision.Jun 29 2017, 9:59 AM

Harbormaster completed remote builds in B10184: Diff 30202.Jun 29 2017, 9:59 AM

Herald added a subscriber: ae. · View Herald TranscriptJun 29 2017, 9:59 AM

krzysztof.galazka_intel.com added a reviewer: Intel Networking.Jun 29 2017, 10:00 AM

Proper size used for TSO.

Harbormaster completed remote builds in B10186: Diff 30204.Jun 29 2017, 10:05 AM

sbruno requested changes to this revision.Jul 3 2017, 6:38 PM

sbruno added inline comments.

sys/net/iflib.c
2933 ↗	(On Diff #30204)	Hrm ... small typo here. Should be scctx->isc_tx_tso_segsize_max

This revision now requires changes to proceed.Jul 3 2017, 6:38 PM

Closed by commit rS320611: iflib - flib_busdma_load_mbuf_sg used isc_tx_maxsize as max semgent size. (authored by sbruno). · Explain WhyJul 3 2017, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

iflib.c

10 lines

Diff 30367

View Options

iflib - use proper max segment size for DMAClosedPublicActions