uefisign.c: Plug memory leaks.
AcceptedPublic
Actions

Authored by delphij on Jun 28 2017, 4:55 AM.

Tags

None

Referenced Files

	F82054652: D11388.diff
	Thu, Apr 25, 1:47 AM

	Unknown Object (File)
	Jan 5 2024, 5:37 PM

	Unknown Object (File)
	Dec 25 2023, 9:38 AM

	Unknown Object (File)
	Dec 20 2023, 6:14 AM

	Unknown Object (File)
	Aug 31 2023, 3:15 PM

	Unknown Object (File)
	May 26 2023, 12:06 PM

	Unknown Object (File)
	Apr 1 2023, 5:41 PM

Subscribers

imp

Details

Reviewers

trasz
emaste

Summary

Plug memory leaks.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 10162
Build 10585: arc lint + arc unit

Event Timeline

delphij created this revision.Jun 28 2017, 4:55 AM

Herald added a subscriber: imp. · View Herald TranscriptJun 28 2017, 4:55 AM

Harbormaster completed remote builds in B10162: Diff 30160.Jun 28 2017, 4:55 AM

emaste added inline comments.Dec 19 2017, 2:36 PM

usr.sbin/uefisign/uefisign.c
352–355	early exit would simplify slightly and reduce indentation, case 'c': if (certpath != NULL) err(1, "-c can only be specified once"); certpath = checked_strdup(optarg); break;

linimon retitled this revision from Plug memory leaks. to uefisign.c: Plug memory leaks..Jul 19 2018, 5:22 AM

emaste accepted this revision.Mar 21 2023, 4:12 PM

This revision is now accepted and ready to land.Mar 21 2023, 4:12 PM

The exit vs return stuff I don't understand how that really changes anything...

Otherwise I agree with ed.

Revision Contents
Changeset List

Path

Size

usr.sbin/

uefisign/

uefisign.c

19 lines

Diff 30160

View Options

usr.sbin/uefisign/uefisign.c

uefisign.c: Plug memory leaks.AcceptedPublicActions