kerberos5/lib/libkrb5 build time warning fixes
Diff Detail
Diff Detail
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 9674 Build 10114: arc lint + arc unit
Event Timeline
Comment Actions
Changelog:
Pre-fix warnings are at: https://gist.github.com/aprieger-llnw/84fc35f2fb992bb96da5e8bb88f03086
- crypto/heimdal/lib/krb5/rd_cred.c
- Warnings:
- warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
- Fixes:
- changed the abs() function to labs() to handle the long argument on line 225
- Warnings:
- crypto/heimdal/lib/krb5/rd_priv.c
- Warnings:
- warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
- Fixes:
- changed the abs() function to labs() to handle the long argument on line 139
- Warnings:
- crypto/heimdal/lib/krb5/rd_req.c
- Warnings:
- warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
- Fixes:
- changed the abs() function to labs() to handle the long argument on line 444
- Warnings:
- crypto/heimdal/lib/krb5/rd_safe.c
- Warnings:
- warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
- Fixes:
- changed the abs() function to labs() to handle the long argument on line 162
- Warnings:
- crypto/heimdal/lib/krb5/ticket.c
- Warnings:
- warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type 'int' which may cause truncation of value [-Wabsolute-value]
- Fixes:
- changed the abs() function to labs() to handle the long argument on lines 779 and 783
- Warnings:
[Note: additional warnings upon building kerberos5/lib/libkrb5 warning: taking the absolute value of unsigned type 'LR_TYPE' (aka 'enum LR_TYPE') has no effect [-Wabsolute-value] in file crypto/heimdal/lib/krb5/init_creds_pw.c however, I found no solution without altering the structure of the code]