Page MenuHomeFreeBSD

security/openssl: Fix SRTP issue and cleanup
AbandonedPublic

Authored by brnrd on Apr 27 2017, 1:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:42 AM
Unknown Object (File)
Sep 21 2023, 5:31 PM
Unknown Object (File)
Sep 11 2023, 4:44 AM
Unknown Object (File)
Jul 1 2023, 12:48 AM
Unknown Object (File)
Jun 30 2023, 2:02 PM
Subscribers
None

Details

Reviewers
feld
mat
Summary
security/openssl: Fix SRTP issue and cleanup

 - Remove ssl/srtp.h patch as it breaks srtp[1][2]
 - Remove unneccessary test/testtls patch
 - Add SSL3 option dependent test/testssl patch
 - Remove crypto/evp/openbsd_hw.c patch (not compiled)
 - Remove crypto/md5/md5.c output formatting patch
 - Add -Werror -Qunused-arguments CFLAGS for better QA

[1] https://github.com/creytiv/re/issues/48
[2] https://github.com/openssl/openssl/commit/383f0e349f0516440a37db29a6b81b8f6c49207f

Reported by:	libre project [1]
Differential_Revision:

The srtp.h patch was actually applied twice. The line was in the code
twice and should've been removed only once. See link [2]. This error
also exists in the base OpenSSL version. Separate review coming up.

Test Plan
  • Build
  • make test (All OK)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 8935
Build 9326: arc lint + arc unit