Add a new parameter to restrict jails from binding to privileged ports

[allanjude]

Summary

Submitted By: Matt Miller <[e-mail]>
PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217728

[smh]

Some style nits but otherwise LGM

sys/kern/kern_jail.c

3314 ↗

(On Diff #26830)

Personally I would remove the else, but this follows the existing file style.

usr.sbin/jail/config.c

101 ↗

(On Diff #26830)

missing tab?

[cem]

LGTM, modulo the same nits as smh@.

[allanjude]

sys/kern/kern_jail.c

3314 ↗

(On Diff #26830)

keeping this as-is, as it the style in the rest of this switch block

usr.sbin/jail/config.c

101 ↗

(On Diff #26830)

it does line up with all of the other tabs, but fixing anyway

[allanjude]

Fix style nits from smh@

[cem]

usr.sbin/jail/config.c

101 ↗

(On Diff #26848)

Was this really too wide?

[allanjude]

usr.sbin/jail/config.c

101 ↗

(On Diff #26848)

If you look at the file in !phabricator, all of the 0s line up perfectly at the tab stop. due to the length of the allow MIB, there was no room for a tab without shifting to the next tab stop. so I did what the file had done for exec.system_jail_user

[jamie]

You don't need the KP_ALLOW_RESERVED_PORTS in jailp.h and config.c - you can just leave these files untouched. The KP_* defines are for parameters that are internally referenced somewhere within jail(8). That includes most of the allow.* parameters, only to handle back-compatibility with the security.jail.*_allowed sysctls.

The other changes (the kernel part) look good.

[allanjude]

Update with feedback from jamie@

[wblock]

Please update .Dd also.