Page MenuHomeFreeBSD

Update digikam to 5.5.0 (kf5 based)
AbandonedPublic

Authored by tcberner on Mar 28 2017, 9:23 PM.

Details

Reviewers
adridg
rakuco
mat
Group Reviewers
kde
portmgr
O5: Ports Framework(Owns No Changed Paths)
Summary
  • Rename the ports and get rid of the -kde4 suffix.
  • Simplify the kipi-plugins-<foo> -> only graphics/kipiplugins remains
  • Simplify digikam, digikam-docs, digikam-l10n into one single port.
  • Import marble, libkface, libksane, libkexiv2, libkdcraw from applications 16.x and either move or replace them (if the only consumer was one of the others, or digikam).
  • MOVED is maybe not correct yet
Test Plan
  • doublecheck INDEX
  • exp-run

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 8591
Build 8905: arc lint + arc unit

Event Timeline

tcberner edited subscribers, added: rakuco, adridg, kde; removed: Contributor Reviewers (ports).

Wow, it only took me 4 tries to add reviers

astro/libkgeomap/Makefile
0

Please don't add more Created by lines, especially if you're not creating it.

13

Don't add this, just don't merge it to 2017Q1 as 2017Q2 is merely days away.

astro/marble-kde4/Makefile
32–35

don't create ports with commented out lines.

astro/marble/Makefile
3

Don't add more created by lines.

graphics/libkface/Makefile
12

same here, 2017Q1 is almost dead.

multimedia/QtAV/Makefile
38 ↗(On Diff #26738)

Never set this when using USE_GITHUB. If it seems you need to do it, it is most likely you did something silly before. In this case, the silly bit being the GH_PROJECT line.

net/libkvkontakte/Makefile
20

If this is really 5.0.0, you should probably ask upstream to add a tag to the repository. If it is a random commit you selected, you should not call it 5.0.0. :-)

net/libmediawiki/Makefile
20

same here.

arc does not like my checkout... give me a minute to upload the diff...

astro/libkgeomap/Makefile
0

I got rid of them in all the kf5-versioned ones. They were most certainly not created by the old creators.

astro/marble-kde4/Makefile
32–35

That was a pre-existing condition :D

net/libkvkontakte/Makefile
20

That was inspired by archlinux. I now switched it to 4.7.0 wich is the actual version defined in the CMakeLists.txt.

net/libmediawiki/Makefile
20

Not quite sure, if the 5.5.0 I have now (so-version) is the better choice.

tcberner marked 4 inline comments as done.
tcberner marked an inline comment as not done.Mar 29 2017, 9:21 AM
tcberner added inline comments.
graphics/libkface/Makefile
12

oops, forgot that one..

tcberner marked an inline comment as not done.
  • get rid of the missec opencv work around
  • define correct license in multimedia/QtAV as reported by @rakuco

How about we start with landing multimedia/qtav separately? I think you're the only fan of huge diffs here :-)

tcberner retitled this revision from Update digikam to 5.4.0 (kf5 based) to Update digikam to 5.5.0 (kf5 based).

I just noticed that 5.5.0 was released.

How about we start with landing multimedia/qtav separately? I think you're the only fan of huge diffs here :-)

Sure :)

multimedia/QtAV/Makefile
32 ↗(On Diff #26766)

This is the default, please remove.

net/libkvkontakte/Makefile
20

You actually switched to 4.70.0 :-)

How about we start with landing multimedia/qtav separately? I think you're the only fan of huge diffs here :-)

Sure :)

The diff is mostly huge because of all the removed files :-)

tcberner edited the summary of this revision. (Show Details)

hide kipipluin_vkkontakte.desktop

Regenerate against curren ports tree.

astro/marble/Makefile
28

This looks like whitespace noise that could be removed from the patch.

31

Same here.

graphics/digikam/Makefile
5

This can be removed.

graphics/libkipi/pkg-descr
3 ↗(On Diff #27199)

Whitespace change.

net/libkvkontakte/Makefile
4

The version number is not attached to the specific commit in GH_TAGNAME, so I think it's better to use something like 4.70.0.20160306 (the date of that commit).

net/libmediawiki/Makefile
4

Same here.

  • Remove whitespace changes
  • Add dates to portversions of libmediawiki and libkvkontakte
graphics/digikam/Makefile
5

really? -- I thought PORTEPOCH has to stay for ever and ever?

graphics/digikam/Makefile
5

Oops, you're right. I thought the package name had changed, but indeed I guess PORTEPOCH needs to stay. I think it also makes sense to preserve the "Created by" line at the beginning in this case.

adamw added inline comments.
graphics/digikam/Makefile
5

Yes. The "Created by" line must never be removed without instruction by the original author.

Readd 'Created by' line in graphics/digkikam. I still dropped it in graphics/libkipi and graphics/libkdcraw as the original ports have been copied to a new location.
Or do the newly added ones still need the old creator in them?

Btw: A slight disadvantage of this partial import of KDE Applicatiosn 16.12.3 parts is that the localizitions will be missing. We could wait for the 17.04 release, in which localization is shipped with the applications and no longer in kde-l10n-packages.

Readd 'Created by' line in graphics/digkikam. I still dropped it in graphics/libkipi and graphics/libkdcraw as the original ports have been copied to a new location.
Or do the newly added ones still need the old creator in them?

It depends on when you are landing this, I'll be phasing out the Created by lines this week or the next :-)

By now, the uncomfortable situation with libmediawiki and libvkontakte is (partly) resolved upstream, with real releases of those libraries. There is also a digikam 5.6.0 in the meantime. So this is probably overcome-by-events by now.

Sorry, I forgot I had an open review for this. Commited in rP468520.