Page MenuHomeFreeBSD
Differential D10073

Fix memory leak in memcontrol
AcceptedPublic
Actions

Authored by trix_juniper.net on Mar 21 2017, 1:16 PM.
Tags
None
Referenced Files
F81686564: D10073.diff
Fri, Apr 19, 10:45 PM
Unknown Object (File)
Sun, Apr 7, 8:00 AM
Unknown Object (File)
Dec 20 2023, 1:28 AM
Unknown Object (File)
Dec 13 2023, 6:27 AM
Unknown Object (File)
Sep 27 2023, 3:45 PM
Unknown Object (File)
Aug 7 2023, 5:35 AM
Unknown Object (File)
Jul 24 2023, 1:00 AM
Unknown Object (File)
Jun 8 2023, 4:24 AM
View All 11 Files
Subscribers
ed
imp

Details

Reviewers
eadler
Summary

memcontrol.c clearfunc
Free 'owner' after use

Test Plan

Use clang's static analyzer, scan-build, to find the problem and later to show resolution.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

trix_juniper.net created this revision.Mar 21 2017, 1:16 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 21 2017, 1:16 PM
ed accepted this revision.Mar 21 2017, 2:32 PM
ed added inline comments.
usr.sbin/memcontrol/memcontrol.c
280

Technically speaking you should also put a free() call above the strdup()... :-)

This revision is now accepted and ready to land.Mar 21 2017, 2:32 PM
ed removed a reviewer: ed.Nov 21 2017, 9:43 PM
This revision now requires review to proceed.Nov 21 2017, 9:43 PM
eadler accepted this revision.Apr 21 2018, 4:55 PM
This revision is now accepted and ready to land.Apr 21 2018, 4:55 PM
eadler added a subscriber: ed.Apr 21 2018, 4:55 PM

obv address @ed's comments too

Revision Contents
Changeset List

PathSize
usr.sbin/
memcontrol/
1 line

Diff 26492

View Options

usr.sbin/memcontrol/memcontrol.c

Loading...