Page MenuHomeFreeBSD

libc/tests: Fix installation without MK_TOOLCHAIN
ClosedPublic

Authored by markj on May 1 2024, 1:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 2, 1:22 PM
Unknown Object (File)
Tue, May 28, 12:35 PM
Unknown Object (File)
May 4 2024, 4:47 PM
Unknown Object (File)
May 2 2024, 10:35 PM
Unknown Object (File)
May 2 2024, 9:01 PM
Unknown Object (File)
May 2 2024, 6:19 PM
Subscribers

Details

Summary

There is some strange conditional logic here to avoid building a
particular test if a certain UBSAN library isn't present. This causes
build failures for me when doing an "installworld WITHOUT_TOOLCHAIN=",
which I do frequently during tests. (This failure appeared for me only
very recently, I'm not quite sure why.)

I presume the problem is that SYSROOT is unset during installworld, so
the build sees the host's copy of libclang_rt.ubsan_standalone.a and
then tries to install a binary that wasn't built during buildworld.
Assuming that this is correct, try to make the check a bit less fragile.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.May 1 2024, 1:44 AM

I will go ahead and commit this if there aren't any objections. This bug just bit me again.

This revision is now accepted and ready to land.Tue, May 28, 6:00 AM