Page MenuHomeFreeBSD

Always update uefi boot entry in bootconfig
AcceptedPublic

Authored by linnemannr_gmail.com on Nov 9 2023, 8:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, May 13, 4:33 AM
Unknown Object (File)
Sun, May 12, 2:06 AM
Unknown Object (File)
Apr 26 2024, 1:47 AM
Unknown Object (File)
Apr 8 2024, 1:37 PM
Unknown Object (File)
Feb 3 2024, 8:18 AM
Unknown Object (File)
Jan 18 2024, 1:21 PM
Unknown Object (File)
Jan 13 2024, 12:44 PM
Unknown Object (File)
Dec 23 2023, 2:56 AM

Details

Summary

Change 40923b0c81cc introduced a conditional check on BSDINSTALL_CONFIGCURRENT
to control whether or not to run efibootmgr to add and activate and entry for
the loader installed to the destination ESP. This prevents diskless scripted
installers from installing a bootable system where the EFI boot entry does not
already exist.

This change removes the conditional on BSDINSTALL_CONFIGCURRENT, so that on a
diskless installer the boot entry is added and activated as expected.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 54358
Build 51248: arc lint + arc unit

Event Timeline

imp added a reviewer: brd.

This makes sense to me, FWIW. The poorly-named BSDINSTALL_CONFIGCURRENT is supposed to be about whether or not to configure the current system’s network to match what is being configured for the installed system. Normally you do them both at the same time, but for diskless/netbooted you want to keep your existing network connection during the installer. Having it also affect whether you call efibootmgr (whilst still modifying the ESP!) like it does today really doesn’t make sense.

This revision is now accepted and ready to land.Dec 15 2023, 3:46 PM

In addition to what's been said, this won't affect other installation scenarios adversely that I can tell.