Page MenuHomeFreeBSD

mpi3mr: Enqueue request from mpi3mr_prepare_sgls
AcceptedPublic

Authored by imp on Oct 30 2023, 2:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 18, 9:57 AM
Unknown Object (File)
Thu, May 9, 12:33 PM
Unknown Object (File)
Wed, May 1, 9:39 AM
Unknown Object (File)
Tue, Apr 23, 1:54 PM
Unknown Object (File)
Mar 31 2024, 6:07 AM
Unknown Object (File)
Mar 3 2024, 4:49 AM
Unknown Object (File)
Jan 17 2024, 6:02 AM
Unknown Object (File)
Dec 23 2023, 12:40 AM
Subscribers
None

Details

Summary

To cope with temporary shortages, busdma has a callback mechanism to
fill in the dma SGLs. This differs from Linux. The callback will always
be called with the resources it needs to do the I/O. Move enqueueing of
the command to the hardare to the end of mpi3mr_prepare_sgls. Adjust
error detection to treat EINPROGRESS as not an error. Tweak some error
handling for failed dma loading in the callback routine (though it's
unclear how those can happen absent other bugs). Add comment for some
checks that should never happen, and should be asserts instead.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 54208
Build 51098: arc lint + arc unit

Event Timeline

imp requested review of this revision.Oct 30 2023, 2:13 AM
imp created this revision.

Not familiar with this driver, but the changes look OK to me.

This revision is now accepted and ready to land.Oct 30 2023, 3:32 PM