Page MenuHomeFreeBSD
Differential D39774

multimedia/obs-studio: fix type conversion error on libftl over new version clang
ClosedPublic
Actions

Authored by aokblast on Apr 24 2023, 8:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 3, 12:31 AM
Unknown Object (File)
Tue, May 28, 8:57 AM
Unknown Object (File)
Tue, May 28, 8:57 AM
Unknown Object (File)
Tue, May 28, 8:55 AM
Unknown Object (File)
Sun, May 26, 7:06 PM
Unknown Object (File)
May 5 2024, 1:08 AM
Unknown Object (File)
May 4 2024, 10:57 AM
Unknown Object (File)
May 3 2024, 3:14 AM
View All 31 Files
Subscribers
mat
yuri
Contributor Reviewers (ports)

Details

Reviewers
lwhsu
yuri
Commits
R11:1d27f9bfb88a: multimedia/obs-studio: Fix build on -CURRENT
Summary

obs-studio cannot be compiled at -CURRENT due to some type conversion error. I fixed it by force conversion.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aokblast created this revision.Apr 24 2023, 8:04 AM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptApr 24 2023, 8:04 AM
aokblast requested review of this revision.Apr 24 2023, 8:04 AM
Harbormaster completed remote builds in B51145: Diff 120908.Apr 24 2023, 8:04 AM
aokblast added a reviewer: lwhsu.Apr 24 2023, 8:04 AM
aokblast edited the summary of this revision. (Show Details)Apr 24 2023, 8:11 AM
lwhsu added a reviewer: yuri.Apr 24 2023, 9:46 PM
lwhsu added a subscriber: yuri.

Hi @yuri ,

As upstream is using git module https://github.com/obsproject/obs-studio/tree/master/plugins/obs-outputs and its upstream has been archived https://github.com/microsoft/ftl-sdk , I am afraid we need to patch this locally first. What do you think?

@i19780219111_kimo.com , I think we can still open an issue in https://github.com/obsproject/obs-studio/ and see if they want to just drop that lib, or import it and patch in their repository.

lwhsu retitled this revision from fix type conversion error on libftl over new version clang to multimedia/obs-studio: fix type conversion error on libftl over new version clang.May 2 2023, 9:30 PM
yuri accepted this revision.May 24 2023, 4:59 PM

Hi Li-Wen Hsu,

Sorry for the delay, I missed this patch.

Please commit it.

Thank you and sorry again,
Yuri

This revision is now accepted and ready to land.May 24 2023, 4:59 PM
Closed by commit R11:1d27f9bfb88a: multimedia/obs-studio: Fix build on -CURRENT (authored by aokblast, committed by lwhsu). · Explain WhyMay 25 2023, 8:27 PM
This revision was automatically updated to reflect the committed changes.
lwhsu added a commit: R11:1d27f9bfb88a: multimedia/obs-studio: Fix build on -CURRENT.

Revision Contents
Changeset List

PathSize
multimedia/
obs-studio/
files/
11 lines

Diff 122442

View Options

multimedia/obs-studio/files/patch-plugins_obs-outputs_ftl-sdk_libftl_ingest.c

Loading...