Don't require tty for install-missing-packages
Needs ReviewPublic
Actions

Authored by guest-patmaddox on Oct 29 2022, 10:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, May 12, 4:44 PM

	Unknown Object (File)
	Sat, May 11, 12:55 AM

	Unknown Object (File)
	Fri, May 10, 11:09 AM

	Unknown Object (File)
	Apr 8 2024, 5:24 PM

	Unknown Object (File)
	Feb 13 2024, 12:10 AM

	Unknown Object (File)
	Dec 13 2023, 6:54 AM

	Unknown Object (File)
	Oct 11 2023, 6:17 PM

	Unknown Object (File)
	Oct 11 2023, 2:02 PM

Subscribers

Details

Reviewers

None

Group Reviewers

portmgr

Summary

Fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267416

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

guest-patmaddox requested review of this revision.Oct 29 2022, 10:31 PM

guest-patmaddox created this revision.

This is my first attempt at a code contribution to FreeBSD... hopefully I'm going about it the right way.

Anyway, I came across an issue when running make install-missing-packages on Cirrus CI, which has no TTY. This little change fixes it.

I admittedly don't know what the consequences of this change are. It looks like the -o flag was added in https://reviews.freebsd.org/D23795

Maybe it needs to have some sort of check to see if there's a TTY, and conditionally add the -o?

@0mp @mat @tobik care to weigh in?

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

2 lines

Diff 112391

View Options

Don't require tty for install-missing-packagesNeeds ReviewPublicActions