Page MenuHomeFreeBSD
Differential D33417

Do not call iommu_map_msi when ctx is NULL
Needs ReviewPublic
Actions

Authored by jsm on Dec 13 2021, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 22, 8:20 PM
Unknown Object (File)
Mar 3 2024, 2:01 PM
Unknown Object (File)
Dec 20 2023, 7:21 AM
Unknown Object (File)
Oct 28 2023, 4:19 AM
Unknown Object (File)
Aug 24 2023, 3:52 AM
Unknown Object (File)
May 19 2023, 3:35 AM
Unknown Object (File)
May 3 2023, 7:39 PM
Unknown Object (File)
Apr 9 2023, 1:18 AM
View All 12 Files
Subscribers
andrew
dsl
emaste
imp

Details

Reviewers
manu
Group Reviewers
Contributor Reviews (src)
Summary

Building arm64 kernel on Pinebook Pro with IOMMU enabled, and an populated pci slot (with an m.2 ssd) the kernel fails at iommu_map_msi at domain = ctx->domain, because ctx is null. Add a test if ctx is null before the call.

Test Plan

The patch works for me.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jsm created this revision.Dec 13 2021, 5:53 PM
Herald added a reviewer: manu. · View Herald TranscriptDec 13 2021, 5:53 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
jsm requested review of this revision.Dec 13 2021, 5:53 PM
dsl added a subscriber: dsl.Dec 26 2021, 9:45 PM
dsl added a comment.Dec 26 2021, 9:48 PM

I've just got a kernel panic at the same place with IOMMU enabled and DPAA2 driver WIP on Honeycomb board.

Revision Contents
Changeset List

PathSize
sys/
arm64/
arm64/
2 lines

Diff 99945

View Options

sys/arm64/arm64/gicv3_its.c

Loading...