Add myself (junovitch / Jason Unovitch) to ports committers (doc)
ClosedPublic
Actions

Authored by junovitch on Jul 31 2015, 10:19 PM.

Details

Reviewers

pgollucci
delphij
feld

Summary

Proposed commit message:

Add myself (junovitch / Jason Unovitch) to ports committers

- Add authors.ent entry
- Add junovitch@FreeBSD to contrib.committers.xml
- Add news item to news.xml
- Add my PGP key
- Fix PGP key sorting while I'm there

Approved by:    delphij (mentor)

While here this fixes ordering around my name:
...
Turner (andrew@)
Tymoshenko (gonzo@)
UMEMOTO (ume@)
Unovitch (junovitch@)
Uphoff (ups@)
...

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

junovitch updated this revision to Diff 7558.Jul 31 2015, 10:19 PM

junovitch retitled this revision from to Add myself (junovitch / Jason Unovitch) to ports committers.

junovitch updated this object.

junovitch edited the test plan for this revision. (Show Details)

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJul 31 2015, 10:19 PM

junovitch retitled this revision from Add myself (junovitch / Jason Unovitch) to ports committers to Add myself (junovitch / Jason Unovitch) to ports committers (doc).Jul 31 2015, 10:28 PM

junovitch edited reviewers, added: feld, delphij, pgollucci; removed: Contributor Reviewers (ports).

Approved (but please take a look at the inline comment).

head/share/pgpkeys/pgpkeys-developers.xml
2134	This is not mentioned in your commit message, and should be mentioned as something like "Sort PGP key entities while I'm there", so please adjust your commit message accordingly. N.B. For larger changes, however, generally speaking two commits should be used to separate change into two logical sets, for this one, doing so would be an overkill, though.