Page MenuHomeFreeBSD

pf tests: test ALTQ CBQ on top of if_vlan
ClosedPublic

Authored by kp on Aug 23 2021, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 16, 12:32 AM
Unknown Object (File)
Wed, May 15, 7:30 AM
Unknown Object (File)
Sun, May 12, 12:19 PM
Unknown Object (File)
Wed, May 1, 10:06 PM
Unknown Object (File)
Wed, May 1, 4:18 AM
Unknown Object (File)
Mon, Apr 29, 9:18 AM
Unknown Object (File)
Apr 1 2024, 3:49 AM
Unknown Object (File)
Mar 7 2024, 11:57 PM

Details

Summary

The main purpose of this test is to verify that we can use ALTQ on top
of if_vlan, but while we're here we also exercise the CBQ code. There's
already a basis test for HFSC, so it makes sense to test another
algorithm while we test if_vlan.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp requested review of this revision.Aug 23 2021, 7:34 PM
donner added inline comments.
tests/sys/netpfil/pf/altq.sh
134

How do you ensure, that the packets send before are still not delivered, so the queue is empty now? Looks like an scheduling dependency race condition.

How about:

  • prefill the queue (like now)
  • the secondary ping tries to send multiple packets within a short interval
  • check, if all packets of the secondary ping are received back

Make the test slightly more robust by sending 5 packets, all of which we expect
to get dropped and allowing one to make it through.

This revision is now accepted and ready to land.Aug 24 2021, 2:42 PM
This revision was automatically updated to reflect the committed changes.