Point developers to vnode_if.awk when they look for functions like VOP_READ
Needs ReviewPublic
Actions

Authored by 0mp on Nov 12 2020, 5:36 PM.

Details

Reviewers

kib
mjg

Group Reviewers

manpages
Contributor Reviews (src)

Summary

Point developers to vnode_if.awk when they look for functions like VOP_READ

MFC: 2 weeks

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34765
Build 31817: arc lint + arc unit

Event Timeline

0mp created this revision.Nov 12 2020, 5:36 PM

Herald added a reviewer: manpages. · View Herald TranscriptNov 12 2020, 5:36 PM

Herald added a subscriber: imp. · View Herald Transcript

0mp requested review of this revision.Nov 12 2020, 5:36 PM

Harbormaster completed remote builds in B34765: Diff 79476.Nov 12 2020, 5:36 PM

0mp edited the summary of this revision. (Show Details)Nov 12 2020, 5:42 PM

0mp added a reviewer: Contributor Reviews (src).

0mp added reviewers: kib, mjg.Nov 12 2020, 6:58 PM

The mdoc is fine, so okay from manpages, but see inline comment.

share/man/man9/vnode.9
162	It's generally better if we can provide explicit definition rather than definition by analogy to examples. So maybe something like "generates the vnode operation wrapper function implementations, e.g.," is better.

I think it is even more confusing that the vnode_if.c and vnode_if.h files are generated in the kernel build directory, which makes grep in kernel sources confusing.
It would be useful to point out where to look for generated code.

Revision Contents
Changeset List

Path

Size

share/

man/

man9/

vnode.9

11 lines

Diff 79476

View Options

Point developers to vnode_if.awk when they look for functions like VOP_READNeeds ReviewPublicActions