- Remove the useless and deprecated fec protocol.
ClosedPublic
Actions

Authored by araujo on Aug 5 2014, 3:01 AM.

Details

Reviewers

glebius
thompsa
adrian

Summary

The lagg(4) interface is based on trunk(4) interface of OpenBSD;
The FreeBSD is the only system that has the FEC protocol, that is a simple alias
to loadbalance protocol and does not implement the ancient Cisco FEC standard.

It is time to remove it from FreeBSD to avoid any kind of misunderstanding.

Test Plan

Just try to set a lagg(4) interface with laggproto fec.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

araujo updated this revision to Diff 957.Aug 5 2014, 3:01 AM

araujo retitled this revision from to - Remove the useless and deprecated fec protocol..

araujo updated this object.

araujo edited the test plan for this revision. (Show Details)

araujo added reviewers: thompsa, glebius.

araujo added a reviewer: adrian.Aug 8 2014, 3:01 AM

As fec is just an alias to loadbalance I would remove it only from share/man/man4/lagg.4 and any other documentation. This allows ifconfig to keep working and the supporting code in sys/net/if_lagg.c is rather trivial.

Hello thompsa@

Here is a new patch, I only removed the 'fec' entry from lagg(4) and ifconfig(8) man pages. We keep the compatibility.

I'm waiting your review and approval.

Best Regards,

fec_doc.patch1 KBDownload

araujo updated this revision to Diff 1655.Sep 17 2014, 9:53 AM

araujo edited edge metadata.

glebius accepted this revision.Sep 17 2014, 10:00 AM

glebius edited edge metadata.

This revision is now accepted and ready to land.Sep 17 2014, 10:00 AM

Committed at: http://svnweb.freebsd.org/base?view=revision&revision=271733