Differential D41992

Update Opensearch to 2.10
ClosedPublic
Actions

Authored by admin_hackacad.net on Sep 27 2023, 7:19 AM.

Details

Reviewers

romain
acm

Summary

Update Opensearch to 2.10 and change OpenJDK to 17

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

admin_hackacad.net requested review of this revision.Sep 27 2023, 7:19 AM

admin_hackacad.net created this revision.

admin_hackacad.net mentioned this in D41847: Opensearch requires JDK17+.Sep 27 2023, 7:22 AM

Can't test right now but LGTM!

This revision is now accepted and ready to land.Sep 28 2023, 12:38 AM

Go ahead!

I was testing opensearch 2.10.0 with OpenJDK 17 and it is generating lot of WARN messages

[2023-09-29T01:01:21,765][WARN ][o.o.t.TaskManager ] [indexer1] Failed to mark thread execution started for task: [74979]
java.lang.UnsupportedOperationException: Thread CPU time measurement is not supported.

at sun.management.ThreadImpl.verifyThreadCpuTime(ThreadImpl.java:258) ~[?:?]
at sun.management.ThreadImpl.getThreadCpuTime(ThreadImpl.java:277) ~[?:?]
at com.sun.management.internal.HotSpotThreadImpl.getThreadCpuTime(HotSpotThreadImpl.java:52) ~[?:?]
at sun.management.ThreadImpl.getThreadCpuTime(ThreadImpl.java:248) ~[?:?]
at org.opensearch.tasks.TaskResourceTrackingService.getResourceUsageMetricsForThread(TaskResourceTrackingService.java:219) ~[opensearch-2.10.0.jar:2.10.0]
at org.opensearch.tasks.TaskResourceTrackingService.taskExecutionStartedOnThread(TaskResourceTrackingService.java:181) [opensearch-2.10.0.jar:2.10.0]
at org.opensearch.threadpool.TaskAwareRunnable.doRun(TaskAwareRunnable.java:73) [opensearch-2.10.0.jar:2.10.0]
at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52) [opensearch-2.10.0.jar:2.10.0]
at org.opensearch.common.util.concurrent.TimedRunnable.doRun(TimedRunnable.java:59) [opensearch-2.10.0.jar:2.10.0]
at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingAbstractRunnable.doRun(ThreadContext.java:908) [opensearch-2.10.0.jar:2.10.0]
at org.opensearch.common.util.concurrent.AbstractRunnable.run(AbstractRunnable.java:52) [opensearch-2.10.0.jar:2.10.0]
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
at java.lang.Thread.run(Thread.java:833) [?:?]

I think we should keep on JAVA_VERSION=11+ until opensearch project apply some kind of patch file to fix the issue. Using OpenJDK 11 WARN messages are not showed. You can look at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=263881 I think it is related to this issue

https://reviews.freebsd.org/R11:784002c3e7be1b6df1097032b21ef0200b1c74b0