Page MenuHomeFreeBSD

Fix gnu ld
ClosedPublic

Authored by andrew on Apr 1 2015, 9:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 13 2024, 7:50 PM
Unknown Object (File)
Jan 16 2024, 12:18 PM
Unknown Object (File)
Jan 10 2024, 2:56 AM
Unknown Object (File)
Jan 10 2024, 2:56 AM
Unknown Object (File)
Dec 20 2023, 12:52 AM
Unknown Object (File)
Nov 19 2023, 11:42 PM
Unknown Object (File)
Nov 7 2023, 3:16 AM
Unknown Object (File)
Oct 30 2023, 6:27 PM
Subscribers

Details

Reviewers
andrew
mmel
Group Reviewers
ARM
Summary

Process or ignore new ARM EABI object attributes.
Only unaligned access and FP HP extension is processed now, rest is ignored.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mmel retitled this revision from to Fix gnu ld.
mmel updated this object.
mmel edited the test plan for this revision. (Show Details)
mmel added a reviewer: ARM.
mmel set the repository for this revision to rS FreeBSD src repository - subversion.
andrew added inline comments.
contrib/binutils/bfd/elf-bfd.h
1289

We should only change this on arm so to not break other architectures

contrib/binutils/bfd/elf-bfd.h
1289

Outside of ARM, the NUM_KNOWN_OBJ_ATTRIBUTES is used only for size of arrays (assuming we don't have vendor object attributes) - so it looks safe for me. Anyway, I'm fine with #ifdef ARM here.

emaste added inline comments.
contrib/binutils/bfd/elf-bfd.h
1289

I think should be fine to increase it globally - the comment above indicates it should be the max across targets so the code should take this into account.

I'm running a universe, will commit if successful.

This revision is now accepted and ready to land.Apr 3 2015, 7:37 PM
andrew edited reviewers, added: mmel; removed: andrew.

Take to close

This revision now requires review to proceed.Apr 3 2015, 7:38 PM
andrew added a reviewer: andrew.
This revision is now accepted and ready to land.Apr 3 2015, 7:38 PM