Differential D2194

Fix gnu ld
ClosedPublic
Actions

Authored by andrew on Apr 1 2015, 9:01 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 15, 5:53 AM

	Unknown Object (File)
	Mon, Nov 25, 4:09 PM

	Unknown Object (File)
	Mon, Nov 25, 4:09 PM

	Unknown Object (File)
	Mon, Nov 25, 4:09 PM

	Unknown Object (File)
	Mon, Nov 25, 4:09 PM

	Unknown Object (File)
	Nov 21 2024, 12:32 AM

	Unknown Object (File)
	Nov 3 2024, 4:34 PM

	Unknown Object (File)
	Nov 3 2024, 4:34 PM

View All 81 Files

Subscribers

Details

Reviewers

andrew
mmel

Group Reviewers

Summary

Process or ignore new ARM EABI object attributes.
Only unaligned access and FP HP extension is processed now, rest is ignored.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mmel updated this revision to Diff 4567.Apr 1 2015, 9:01 AM

mmel retitled this revision from to Fix gnu ld.

mmel updated this object.

mmel edited the test plan for this revision. (Show Details)

mmel added a reviewer: ARM.

mmel set the repository for this revision to rS FreeBSD src repository - subversion.

andrew added a subscriber: andrew.Apr 1 2015, 9:04 AM

andrew added inline comments.

contrib/binutils/bfd/elf-bfd.h
1289	We should only change this on arm so to not break other architectures

mmel added inline comments.Apr 1 2015, 9:22 AM

contrib/binutils/bfd/elf-bfd.h
1289	Outside of ARM, the NUM_KNOWN_OBJ_ATTRIBUTES is used only for size of arrays (assuming we don't have vendor object attributes) - so it looks safe for me. Anyway, I'm fine with #ifdef ARM here.

emaste added a subscriber: emaste.Apr 1 2015, 2:30 PM

emaste added inline comments.

contrib/binutils/bfd/elf-bfd.h
1289	I think should be fine to increase it globally - the comment above indicates it should be the max across targets so the code should take this into account.

I'm running a universe, will commit if successful.

Committed in rS281048

This revision is now accepted and ready to land.Apr 3 2015, 7:37 PM

Take to close

This revision now requires review to proceed.Apr 3 2015, 7:38 PM

andrew accepted this revision.Apr 3 2015, 7:38 PM

andrew added a reviewer: andrew.

This revision is now accepted and ready to land.Apr 3 2015, 7:38 PM

andrew closed this revision.Apr 3 2015, 7:38 PM

Revision Contents
Changeset List

Path

Size

contrib/

binutils/

bfd/

2 lines

6 lines

include/

elf/

6 lines

Diff 4567

contrib/binutils/bfd/elf-bfd.h

Loading...

contrib/binutils/bfd/elf32-arm.c

Loading...

contrib/binutils/include/elf/arm.h

Loading...