NEW PORT: sysutils/snmp_exporter

[fabian.freyer_physik.tu-berlin.de]

Summary

snmp_exporter is a prometheus exporter for information
gathered from SNMP for use by the Prometheus monitoring
system.

WWW: https://github.com/prometheus/snmp_exporter

See bugzilla: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226223

Test Plan

make install; snmp_exporter_generator generate; service snmp_exporter onestart; test with prometheus instance

[lwhsu]

sysutils/snmp_exporter/files/patch-generator_generator.yml

7 ↗

(On Diff #39767)

This patch deletes more than what left in the target file. How about just having a file with the content we need, and replace this file in post-patch?

sysutils/snmp_exporter/files/patch-generator_main.go

8 ↗

(On Diff #39767)

I recommend respect ${PREFIX} instead of hard-coding /usr/local/

[mat]

sysutils/snmp_exporter/Makefile

23 ↗

(On Diff #39767)

Should probably be with the USE_* before. See Chapter 15. Order of Variables in Port Makefiles.

[fabian.freyer_physik.tu-berlin.de]

addressed some comments

[fabian.freyer_physik.tu-berlin.de]

sysutils/snmp_exporter/files/patch-generator_main.go

8 ↗

(On Diff #39767)

I'm replacing this in the post-patch target.

[lwhsu]

sysutils/snmp_exporter/files/patch-generator_main.go

8 ↗

(On Diff #39767)

Oh, just saw that. One nit, from bsd.port.mk:

LOCALBASE             - Where ports install things.
PREFIX                - Where *this* port installs its files.

So it would be better to use ${PREFIX} in post-patch target.

Also, a very minor point, sometimes we use something like %%PREFIX%% as the keyword when patching, then doing real replacement later to prevent unwanted side-affect, but here it is just fine.

[fabian.freyer_physik.tu-berlin.de]

Fixed that, using ${PREFIX} now.

[fabian.freyer_physik.tu-berlin.de]

@lwhsu while you're here, any chance you could take a look at D14537?